Skip to content

Utf8ByteBufCharsetDecoder BufferOverflowException when several non US-ASCII chars are split #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slandelle opened this issue Feb 14, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@slandelle
Copy link
Contributor

When multiple non US-ASCII chars are split over several chunks, Utf8ByteBufCharsetDecoder crashes with BufferOverflowException.

This happens because we don't clear the splitCharBuffer in-between and only do so once decoding is done.

@slandelle slandelle added this to the 2.0.29 milestone Feb 14, 2017
@slandelle slandelle self-assigned this Feb 14, 2017
slandelle added a commit that referenced this issue Feb 14, 2017
…close #1357

Motivation:

When multiple non US-ASCII chars are split over several chunks,
Utf8ByteBufCharsetDecoder crashes with BufferOverflowException.

This happens because we don't clear the splitCharBuffer in-between and
only do so once decoding is done.

Modifications:

Clear Utf8ByteBufCharsetDecoder#splitCharBuffer once char is complete

Result:

No more BufferOverflowException
slandelle added a commit to gatling/gatling that referenced this issue Feb 15, 2017
Motivation:

Ship fix for
AsyncHttpClient/async-http-client#1357

Modification:

Upgrade AHC 2.0.29

Result:

AHC 2.0.29 upgraded
slandelle added a commit to gatling/gatling that referenced this issue Feb 23, 2017
Motivation:

Ship fix for
AsyncHttpClient/async-http-client#1357

Modification:

Upgrade AHC 2.0.29

Result:

AHC 2.0.29 upgraded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant