Skip to content

Don't stall when failing to create SslHandler #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slandelle opened this issue Feb 21, 2017 · 0 comments
Closed

Don't stall when failing to create SslHandler #1361

slandelle opened this issue Feb 21, 2017 · 0 comments
Assignees
@slandelle
Labels
Defect
Milestone
2.0.30

Comments

@slandelle
Copy link
Contributor

Creating a SslHandler can crash, for example when there's a typo in the enabled protocols.
When this happens, the exception is not propagated.
@slandelle slandelle added this to the 2.0.30 milestone Feb 21, 2017
@slandelle slandelle self-assigned this Feb 21, 2017
@slandelle slandelle changed the title Don't crash when failing to create SslHandler Don't stall when failing to create SslHandler Feb 21, 2017
slandelle added a commit that referenced this issue Feb 21, 2017
@slandelle
Don't stall when failing to create SslHandler, close #1361
4d5a856 
Motivation:

Creating a SslHandler can crash, for example when there's a typo in the
enabled protocols.
When this happens, the exception is not propagated.

Modification:

Catch such Exception and notify the NettyConnectListener.

Result:

AHC no longer stalled when such exception happens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slandelle slandelle

Labels
Defect
Projects
None yet
Milestone
2.0.30
Development

No branches or pull requests
1 participant
@slandelle