You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Executor can be <code>null</code>, in that case executor will be executed
* in the thread where completion happens.
However, this doesn't work with the NettyResponseFuture implementation:
java.lang.NullPointerException
at java.util.concurrent.CompletableFuture.screenExecutor(CompletableFuture.java:415)
at java.util.concurrent.CompletableFuture.whenCompleteAsync(CompletableFuture.java:2142)
at org.asynchttpclient.netty.NettyResponseFuture.addListener(NettyResponseFuture.java:257)
I'm happy to submit a pull request for this issue, if you can indicate how you want it fixed (i.e. update the documentation to reflect current behavour, or change behaviour to match documentation).
The text was updated successfully, but these errors were encountered:
Thanks for reporting! I guess it would be better to try to implement what the doc says. But if it turns out to be difficult, let's update the doc.
And sure, PR welcome :)
joedj
changed the title
ListenableFuture#addCallbacks with null executor throws NPE
ListenableFuture#addListener with null executor throws NPE
Mar 27, 2017
joedj
pushed a commit
to joedj/async-http-client
that referenced
this issue
Mar 27, 2017
ListenableFuture#addListener javadoc says:
However, this doesn't work with the
NettyResponseFuture
implementation:I'm happy to submit a pull request for this issue, if you can indicate how you want it fixed (i.e. update the documentation to reflect current behavour, or change behaviour to match documentation).
The text was updated successfully, but these errors were encountered: