Skip to content

asyncHandler is not unwrapped before instanceof tests #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jozsefilles opened this issue Jun 28, 2017 · 2 comments
Closed

asyncHandler is not unwrapped before instanceof tests #1432

jozsefilles opened this issue Jun 28, 2017 · 2 comments

Comments

@jozsefilles
Copy link

When using ThrottleRequestFilter, my custom TransferCompletionHandler is getting wrapped into an AsyncHandlerWrapper.

This later fails the type check in WriteListener's constructor so that onHeadersWritten() is never called:
this.progressAsyncHandler = future.getAsyncHandler() instanceof ProgressAsyncHandler ? (ProgressAsyncHandler<?>) future.getAsyncHandler() : null;

The same might apply to the NettyRequestSender's writeRequest method for testing against the types TransferCompletionHandler and AsyncHandlerExtensions.

@slandelle
Copy link
Contributor

Dup of #1314, fixed in 2.1 branch (won't be in 2.0 one)

@jozsefilles
Copy link
Author

Thanks for pointing into the right direction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants