Skip to content

ThrottleRequestFilter swallows interfaces #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markus-s24 opened this issue Nov 28, 2016 · 2 comments
Closed

ThrottleRequestFilter swallows interfaces #1314

markus-s24 opened this issue Nov 28, 2016 · 2 comments
Labels
Contributions Welcome! Defect
Milestone
2.1.0

Comments

@markus-s24
Copy link

markus-s24 commented Nov 28, 2016 •
edited
Loading

The ThrottleRequestFilter wraps the AsyncHandler with an AsyncHandlerWrapper. This way all additional interfaces implemented by the originating AsyncHandler get lost. E.g. ProgressAsyncHandler, ResumableAsyncHandler or any custom interfaces.

Suggestion: Maybe use a dynamic proxy which implements all interfaces of the originating AsyncHandler instead of using AsyncHandlerWrapper.
@slandelle
Copy link
Contributor

The Filter API comes from the original author of this library.
I have personally no use for it so far.

Contributions welcome

@markus-s24
Copy link
Author

See #1315

@slandelle slandelle added this to the 2.1.0 milestone Nov 29, 2016
slandelle added a commit that referenced this issue Jan 12, 2017
@slandelle
Fix semaphore not being released on Throwable, see #1314
4dbf11c 
Motivation:

Fix for #1314 introduced a regression where the Semaphore leaks and is
not released on Throwable.

Modification:

Release Semaphore when called handler method is onThrowable too, not
only onComplete.

Result

No more Semaphore leak
@slandelle slandelle mentioned this issue Jun 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contributions Welcome! Defect
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@slandelle @markus-s24