Skip to content

The Netty WebSocket handling does not correctly reassemble fragments into messages #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RickBullotta opened this issue Jan 28, 2013 · 2 comments
Closed

The Netty WebSocket handling does not correctly reassemble fragments into messages #207

RickBullotta opened this issue Jan 28, 2013 · 2 comments
Milestone
1.7.12

Comments

@RickBullotta
Copy link
Contributor

The current implementation of the NettyAsyncHttpProvider and NettyWebSocket do not properly reassemble fragments into messages (as per the web socket spec), nor do they correctly invoke the onFragment and onMessage callbacks. I have create a fix for this but am a Github noob and have no idea how to submit the patches.
@jfarcand
Copy link
Contributor

Easy. Just read https://help.github.com/articles/fork-a-repo

@RickBullotta
Copy link
Contributor Author

Closed per pull request #215

rlubke added a commit that referenced this issue Feb 23, 2013
@rlubke
Grizzly-related changes for #207. By default, fragments will be buffe…
d5b88ee 
…red. Once the last fragment has been received the full message will be passed to the listener.

Original functionality can be re-enabled by setting the BUFFER_WEBSOCKET_FRAGMENTS to false on the GrizzlyAsyncHttpProviderConfig instance.
rlubke added a commit that referenced this issue Feb 23, 2013
@rlubke
Grizzly-related changes for #207. By default, fragments will be buffe…
6ca427d 
…red. Once the last fragment has been received the full message will be passed to the listener.

Original functionality can be re-enabled by setting the BUFFER_WEBSOCKET_FRAGMENTS to false on the GrizzlyAsyncHttpProviderConfig instance.
slandelle pushed a commit that referenced this issue Mar 11, 2013
@RickBullotta
Backport fix for #207
ce7b467
cs-workco pushed a commit to cs-workco/async-http-client that referenced this issue Apr 13, 2023
@artemredkin
make cookie parsing case insensitive (AsyncHttpClient#207)
f8b8de1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.12
Development

No branches or pull requests
2 participants
@jfarcand @RickBullotta