Skip to content

Content-Disposition incorrect handling #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slandelle opened this issue May 17, 2013 · 1 comment
Closed

Content-Disposition incorrect handling #297

slandelle opened this issue May 17, 2013 · 1 comment
Assignees
@slandelle
Milestone
1.7.16

Comments

@slandelle
Copy link
Contributor

If filename is explicitly set to null, Content-Disposition should be sent at all, not set to no-name or forced to the file path.
@ghost ghost assigned slandelle May 17, 2013
slandelle pushed a commit that referenced this issue May 17, 2013
Various multipart fixes, close #296, #297, #298
d8a2e0a
@slandelle
Copy link
Contributor Author

To be ported on master

slandelle pushed a commit that referenced this issue May 17, 2013
Various multipart fixes, close #296, #297, #298
760a911
cs-workco pushed a commit to cs-workco/async-http-client that referenced this issue Apr 13, 2023
@artemredkin
Fix state reverting (AsyncHttpClient#298)
4b4d660 
* fail if we get part when state is endOrError

* Prevent TaskHandler state change after `.endOrError`

Motivation:
Right now if task handler encounters an error, it changes state to
`.endOrError`. We gate on that state to make sure that we do not
process errors in the pipeline twice. Unfortunately, that state
can be reset when we upload body or receive response parts.

Modifications:
Adds state validation before state is updated to a new value
Adds a test

Result:
Fixes AsyncHttpClient#297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slandelle slandelle

Labels
None yet
Projects
None yet
Milestone
1.7.16
Development

No branches or pull requests
1 participant
@slandelle