Skip to content

Response.isRedirected considers 304 as a redirect #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slandelle opened this issue Sep 27, 2013 · 3 comments
Closed

Response.isRedirected considers 304 as a redirect #391

slandelle opened this issue Sep 27, 2013 · 3 comments
Assignees
@slandelle
Milestone
1.7.21

Comments

@slandelle
Copy link
Contributor

No description provided.

@slandelle
Copy link
Contributor Author

@jfarcand @rlubke Agree to only consider 301, 302, 303, 307 and 308 as real redirects?

@rlubke
Copy link
Contributor

rlubke commented Oct 3, 2013

+1

Stephane Landelle wrote:

@jfarcand https://github.com/jfarcand @rlubke
https://github.com/rlubke Agree to only consider 301, 302, 303 and
307 as real redirects?

—
Reply to this email directly or view it on GitHub
#391 (comment).

@jfarcand
Copy link
Contributor

jfarcand commented Oct 3, 2013

+1

@ghost ghost assigned slandelle Oct 3, 2013
slandelle pushed a commit that referenced this issue Oct 3, 2013
Backport #391
d0bc3fc
@alvinlin123 alvinlin123 mentioned this issue Nov 13, 2013
Closed
cs-workco pushed a commit to cs-workco/async-http-client that referenced this issue Apr 13, 2023
@fabianfett @Lukasa
Refactor Request Validation (AsyncHttpClient#391)
bccb075 
- Refactored code from `TaskHandler` into new method `HTTPClient.Request.createRequestHead` that creates an `HTTPRequestHead` and matching `RequestFramingMetadata`
- Added required property `requestFramingMetadata` to `HTTPExecutingRequest`
- Added property `requestFramingMetadata` to `RequestBag`

Co-authored-by: Cory Benfield <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slandelle slandelle

Labels
None yet
Projects
None yet
Milestone
1.7.21
Development

No branches or pull requests
3 participants
@jfarcand @rlubke @slandelle