AsyncHttpClientConfig throws an exception if we pass a managed executor service

[hmashlah]

Glassfish 4 implementation of JavaEE 7 managed executor service throws an exception if a life cycle method is called e.g isShutDown
This method is called in AsyncHttpClientConfig if an applicationThreadPool is passed to it.

[slandelle]

Which version did you use?
Does this happen with the Netty provider too?
Could you provider exact stacktrace, please?

[hmashlah]

I tried using 1.7.19 and 1.7.20 and it did not work (I see that this call is commented on the master but I did not try it)
I am using Netty provider. Following is the stacktrace
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.jboss.weld.injection.producer.DefaultLifecycleCallbackInvoker.invokeMethods(DefaultLifecycleCallbackInvoker.java:89)
... 149 more
Caused by: java.lang.IllegalStateException: Lifecycle operation not supported
at org.glassfish.enterprise.concurrent.AbstractManagedExecutorServiceAdapter.isShutdown(AbstractManagedExecutorServiceAdapter.java:68)
at com.ning.http.client.AsyncHttpClientConfig$Builder.build(AsyncHttpClientConfig.java:1099)
at org.mashlah.MyDownloadService.init(MyDownloadService.java:62)
at org.mashlah.MyDownloadService.init(MyDownloadService.java:58)
... 154 more

[slandelle]

Maybe @rlubke can help on this.

For the record: AHC line: https://github.com/AsyncHttpClient/async-http-client/blob/async-http-client-1.7.19/src/main/java/com/ning/http/client/AsyncHttpClientConfig.java#L1099

[rlubke]

That EE Concurrent Utilities spec states the following for ManagedExecutorServices:

The lifecycle of a ManagedExecutorService is managed by an application server. All lifecycle operations on the >ManagedExecutorService interface will throw a java.lang.IllegalStateException exception. This includes the >following methods that are defined in the java.util.concurrent.ExecutorService interface: awaitTermination(), >isShutdown(), isTerminated(), shutdown(), and shutdownNow().

The branch logic referenced by Stephane tries to prevent the user from passing an ExecutorService that has already been shutdown, however, I given the above, I think we should remove that safety check. If the user in a non EE environment passes an invalid ExecutorService, we can let an error occur then.

[slandelle]

👍

[hmashlah]

That sounds good.
Thanks
On Oct 14, 2013 6:18 PM, "Stephane Landelle" [email protected]
wrote:

[image: 👍]

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/402#issuecomment-26267720
.

[rlubke]

I've pushed 1.7.21-SNAPSHOT to sonatype maven repo. Mind giving it a shot and verify resolution?

[hmashlah]

The problem is resolved. Thanks