Skip to content

Improve multipart logic for grizzly provider #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carryel opened this issue Nov 6, 2013 · 1 comment
Closed

Improve multipart logic for grizzly provider #411

carryel opened this issue Nov 6, 2013 · 1 comment

Comments

@carryel
Copy link
Contributor

carryel commented Nov 6, 2013

Current multipart logic for grizzly provider has some issues.

  • Before writing, default logic allocates all file sources' buffers. I met OOM before actual writing when I tested with a large file.
  • After I improved above first issue, I also met OOM in writing because the write buffer queue(grizzly internal write buffer) would be able to be full. BaseFeeder.java already has the write-flow-control which waits or blocks if server can't be received. So I think this logic can be also applied in multipart logic default.
carryel added a commit to carryel/async-http-client that referenced this issue Nov 6, 2013
(Note) This code/patch should be applied after resolving issue AsyncHttpClient#409 "MultipartBody generates wrong body bytes"
carryel added a commit to carryel/async-http-client that referenced this issue Nov 7, 2013
rlubke added a commit that referenced this issue Nov 11, 2013
@rlubke
Copy link
Contributor

rlubke commented Dec 5, 2013

Closing this one out.

@rlubke rlubke closed this as completed Dec 5, 2013
cs-workco pushed a commit to cs-workco/async-http-client that referenced this issue Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants