Skip to content

closeAsynchronously doesn't shutdown own thread #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slandelle opened this issue Jan 22, 2014 · 1 comment
Closed

closeAsynchronously doesn't shutdown own thread #458

slandelle opened this issue Jan 22, 2014 · 1 comment

Comments

@slandelle
Copy link
Contributor

No description provided.

@ghost ghost assigned slandelle Jan 22, 2014
slandelle pushed a commit that referenced this issue Jan 22, 2014
Make closeAsynchronously shutdown own thread, close #458
f9f9cf4
@slandelle
Copy link
Contributor Author

Revert, stupid

cs-workco pushed a commit to cs-workco/async-http-client that referenced this issue Apr 13, 2023
@Lukasa
Don't crash when hitting long backoffs. (AsyncHttpClient#458)
1081b0b 
Motivation:

If we backoff sufficiently far we can overflow Int64, which will cause
us to crash.

Modifications:

Clamp the backoff value before we convert to Int64.

Results:

No crashes!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slandelle