Skip to content

Support Socks4/5 Proxy #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lekanich opened this issue Apr 11, 2014 · 21 comments
Open

Support Socks4/5 Proxy #533

Lekanich opened this issue Apr 11, 2014 · 21 comments
Assignees

Comments

@Lekanich
Copy link

Can you add support socks proxy for netty provider? It was be wonderfull.

@slandelle
Copy link
Contributor

Contribution welcome

@Lekanich
Copy link
Author

Ok, I will make a new fork and write.

@Lekanich
Copy link
Author

What java version I must use for this? (JAVA 6, 7, 8?)

@jfarcand
Copy link
Contributor

If it's for 2.0, you can use 7. If for 1.8.x, use 6.

@Lekanich
Copy link
Author

What branch is 2.0?

@slandelle
Copy link
Contributor

master

@Lekanich
Copy link
Author

@slandelle Thanks

@slandelle
Copy link
Contributor

@Lekanich Well, you're the one who deserves thanks.
Referencing your Netty WIP: netty/netty#2563

@bchazalet
Copy link

I am interesting in this too and will be keen on contributing.

What's the status of it and is there a wip branch where I can have a look at the current progress and help?

@slandelle
Copy link
Contributor

Hi @bchazalet,

Honestly, I have no idea where SOCKS support in Netty is now. From @trustin's comment here, I'm not sure it has support for client side sockets yet.
If you're interested in contributing, the best way would probably be to first get in touch with the Netty people and make the feature happen there. Then, we'll be able to wrap it in AHC.

@bchazalet
Copy link

thanks for the info @slandelle

@jeffpeiyt
Copy link

ah @bchazalet ... we need this too... as we use ssh tunneling with dynamic forward to local port

@jeffpeiyt
Copy link

@bchazalet , after a year.... does netty support this now?

@slandelle
Copy link
Contributor

AFAIK, Netty 4 now has SOCKS support. But even if AHC 2 (currently in alpha) supports Netty 4, there's no integration for this codec.
Honestly, the best way to make it happen is to contribute it.

@bchazalet
Copy link

@slandelle How would you implement this? Can you throw a couple of pointers on where to start? And what codec are you talking about?

Sorry for the naive questions, but I guess I have a lot of reading on both projects.

@trustin
Copy link

trustin commented Aug 21, 2015

@bchazalet A good starting point would be to look at the test case in Netty:

https://github.com/netty/netty/blob/4.1/handler-proxy/src/test/java/io/netty/handler/proxy/ProxyHandlerTest.java

It tests various cases, but they are essentially same.

  • Insert proxy handlers into the pipeline
  • Attempt to connect to a unresolved address if you want proxy-side DNS resolution
  • Use NoopNameResolverGroup as a resolver.

@egprentice
Copy link

I need socks5 support also.

@hsrzq
Copy link

hsrzq commented Apr 28, 2016

I need too!

@slandelle
Copy link
Contributor

But I don't.
So there's 2 ways to make this happen:

  • contributing: there's some ideas and links in there
  • contracting

@slandelle
Copy link
Contributor

No activity there for a very long time. Closing for now.

@slandelle slandelle added this to the 2.1.0 milestone Jan 12, 2018
@slandelle slandelle reopened this Jan 12, 2018
cs-workco pushed a commit to cs-workco/async-http-client that referenced this issue Apr 13, 2023
- invoke source-kitten with the correct flags
- make location of source-kitten source checkout more robust
@hyperxpro hyperxpro reopened this Nov 11, 2023
@hyperxpro hyperxpro removed this from the 2.1.0 milestone Nov 11, 2023
@hyperxpro hyperxpro self-assigned this Nov 11, 2023
@hyperxpro
Copy link
Member

Adding support for Socks5; PR will be up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants