Cookie max-age is wrong

[slandelle]

Salut,

AsyncHttpProviderUtils.parseCookie sets a -1 max-age for both expired regular cookies and session cookies (that don't have a max-age).

max-age should be an Integer (set to null for session cookies) instead of an int, so that one can tell expired and session cookies apart.

Cheers,

Stephane

[jfarcand]

Salut, do you have a server or test I can look at to see if the fix will works? I will look at the spec.... Thanks!

[slandelle]

I'll try to get one, but that might be difficult.

If you look at the RFC, max-age is definitively optional: http://tools.ietf.org/html/rfc6265#section-4.1.2.2

Maybe AsyncHttpProviderUtils.parseCookie could:

• return -1 for cookies that have neither an expire nor a max age, meaning "never expires"
• return 0 for cookies that have an expire in the past, meaning "expires now"

WDYT?

PS: If you agree with this, I can make a pull request.

[slandelle]

thanks!