Skip to content

Document maxConnectionsPerHost is actually max-connections-per-url #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stepancheg opened this issue Dec 6, 2014 · 0 comments
Closed

Document maxConnectionsPerHost is actually max-connections-per-url #772

stepancheg opened this issue Dec 6, 2014 · 0 comments
Assignees
@slandelle
Labels
Documentation
Milestone
1.9.1

Comments

@stepancheg
Copy link
Contributor

setMaxConnectionsPerHost says that it sets "the maximum number of connections per hosts".

So it sounds like it limits max connections per hostname or per IP, but it is actually max connections per (scheme, host, port), as far as I understood looking at com.ning.http.client.providers.netty.channel.ChannelManager.freeChannelsPerHost.
slandelle pushed a commit that referenced this issue Dec 8, 2014
Fix setMaxConnectionsPerHost javadoc, close #772
77eb5b9
@slandelle slandelle self-assigned this Dec 8, 2014
@slandelle slandelle added this to the 1.9.1 milestone Dec 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slandelle slandelle

Labels
Documentation
Projects
None yet
Milestone
1.9.1
Development

No branches or pull requests
2 participants
@stepancheg @slandelle