Skip to content

JDK provider does not call any callback handler for some exceptions #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stsiano opened this issue Sep 10, 2015 · 3 comments
Closed

JDK provider does not call any callback handler for some exceptions #965

stsiano opened this issue Sep 10, 2015 · 3 comments
Labels
Defect
Milestone
1.9.32

Comments

@stsiano
Copy link

stsiano commented Sep 10, 2015

The JDK provider (in the 1.9.x branch) does not call any callback handler if an exception is thrown within the call() method of JDKAsyncHttpProvider.AsyncHttpUrlConnection.
From my understanding this is wrong; a
asyncHandler.onThrowable(t);
call should be added at the end of the catch block.
@slandelle
Copy link
Contributor

Feel free to provide a fix.
But note that the JDK provider is deprecated and is dropped in AHC2.

@stsiano stsiano mentioned this issue Sep 10, 2015
Merged
@stsiano
Copy link
Author

stsiano commented Sep 10, 2015

I have created a pull request for this.

slandelle added a commit that referenced this issue Sep 10, 2015
@slandelle
Merge pull request #966 from stsiano/1.9.x
ff3250a 
JDK provider does not call any callback handler for some exceptions, close #965
@slandelle slandelle added this to the 1.9.32 milestone Sep 10, 2015
@slandelle
Copy link
Contributor

Thanks

@stsiano stsiano mentioned this issue Sep 11, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Defect
Projects
None yet
Milestone
1.9.32
Development

No branches or pull requests
2 participants
@slandelle @stsiano