Skip to content

Add URI to message of TimeoutException when timeout #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Atry
Copy link

@Atry Atry commented Nov 9, 2015

No description provided.

@slandelle
Copy link
Contributor

Hi @Atry,

What's the motivation for this change? I'd tend to disagree. The point of having the remoteAddress is to be able to detect a failing node in a cluster.

@Atry
Copy link
Author

Atry commented Nov 9, 2015

Isn't the URI the most significant information for a normal request?

As a client, how do you feel when you caught an exception and did not know which URI you were requesting?

@slandelle
Copy link
Contributor

URI wouldn't be sufficient: what about posting a body, what about headers (eg auth token)?

Your real problem is that your losing request context: which you could still have if you were mapping the failure.

The current design:

  • let you have consistent exception messages
  • reduce memory pressure by not storing references to the requests (that can have huge payloads) in possibly expired timeout tasks that have to been pushed out yet out of the timer
  • give you the proper remote address so you can tell cluster nodes

I really need all of those for Gatling, so sorry, I'm going to reject this one, as there's an easy workaround.

@slandelle slandelle closed this Nov 9, 2015
@Atry
Copy link
Author

Atry commented Nov 9, 2015

OK, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants