Skip to content

getPort should work with uppercase scheme #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2016
Merged

getPort should work with uppercase scheme #1125

merged 1 commit into from
Mar 31, 2016

Conversation

jacobtolar
Copy link
Contributor

Fixes #1111

It appears that the 1.8.x branch:

  • Only builds under JDK7
  • Has a bunch of flakey tests (like *RemoteSiteTest)

@slandelle slandelle merged commit 4855d7a into AsyncHttpClient:1.8.x Mar 31, 2016
@slandelle
Copy link
Contributor

Thanks.

As explained in #1111, 1.8 has reached eol.
I can accept contribs and release, though.

@slandelle slandelle added this to the 1.8.17 milestone Mar 31, 2016
@slandelle slandelle self-assigned this Mar 31, 2016
@slandelle
Copy link
Contributor

Released as of 1.8.17

@slandelle slandelle mentioned this pull request Mar 31, 2016
Closed
@jacobtolar jacobtolar deleted the fix-scheme-case branch June 14, 2016 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@slandelle slandelle

Labels
Defect Netty
Projects
None yet
Milestone
1.8.17
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtolar @slandelle