Skip to content

Fix proxy when using JDK provider #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2016

Conversation

malaporte
Copy link
Contributor

Right now it always throws an NPE if it's not bypassed. The culprit is the ka variable (that's in fact always null but hey). There is an if on the first call to setRequestProxy, but none on the 2nd, which is spurious anyway, so I removed it.

@slandelle
Copy link
Contributor

Merging. But honestly, you shouldn't be using the JDK provider. It's a mere toy. I advise you switch to the Netty provider, or better upgrade to AHC2.

@slandelle slandelle added this to the 1.9.39 milestone May 23, 2016
@slandelle slandelle merged commit 282298d into AsyncHttpClient:1.9.x May 23, 2016
@slandelle
Copy link
Contributor

But thanks anyway :)

@malaporte
Copy link
Contributor Author

Oh I'm using the Netty provider alright, except in this one place where someone requires the use of a proxy server using Windows Authentication (gotta love those guys). There the JDK provider works better than Netty, for some reason.

@slandelle
Copy link
Contributor

There the JDK provider works better than Netty, for some reason.

Even with latest versions (there were several fixes in the area)? Would be great to have the expected and actual HTTP sequences so I can fix (you can guess I can't run such cases on my side).

JDK provider went away with AHC2.

@malaporte
Copy link
Contributor Author

Well I did wanted to test but then I found this:

image

Shoot.

@slandelle
Copy link
Contributor

Pity indeed

@malaporte malaporte deleted the fix-npe-in-jdk-proxy branch June 7, 2016 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants