Cleanup IDE warnings #1227
Merged
Cleanup IDE warnings #1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,8 +63,7 @@ public static String encode(Collection<Cookie> cookies) { | |||
| } else { | |||
| Cookie[] cookiesSorted = cookies.toArray(new Cookie[cookies.size()]); | |||
| Arrays.sort(cookiesSorted, COOKIE_COMPARATOR); | |||
| for (int i = 0; i < cookiesSorted.length; i++) { | |||
| Cookie cookie = cookiesSorted[i]; | |||
| for (Cookie cookie : cookiesSorted) { | |||
There was a problem hiding this comment.
Actually, I would tend to disagree here: the original form saves an Iterator. One could argue JIT escape analysis might be able to save it, but maybe not. Netty does the same thing.
There was a problem hiding this comment.
@slandelle what iterator do you mean? This is array, for each in arrays don't use iterator. Compiler extract this loop into your version, It has nothing to do with JIT. I can show you bytecode if you want :).
|
LGTM except for one small nit. Could you please revert this one single change? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation :
IDE highlights a lot of warnings, code hard to read with them.
Modifications :
Removed unnecessary explicit type arguments,
finalfor private methods, replacesforwithfor each.Result :
Cleaner code.