Rewrite NettyResponseFuture using CompletableFuture #1294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good! Please let me review carefully later today. |
slandelle
reviewed
Oct 28, 2016
| @@ -47,24 +45,18 @@ | |||
| * | |||
| * @param <V> the result type | |||
| */ | |||
| public final class NettyResponseFuture<V> extends AbstractListenableFuture<V> { | |||
| public final class NettyResponseFuture<V> implements ListenableFuture<V> { | |||
There was a problem hiding this comment.
So AbstractListenableFuture and RunnableExecutorPair can be removed, as they are replaced with CompletableFuture#whenCompleteAsync, right?
There was a problem hiding this comment.
Yes. Should I remove it?
stepancheg
force-pushed
the
compl-future
branch
from
8f2e1aa to
6326bf3
Compare
|
Update PR with removed |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompletableFutureseems to be as expensive asCountDownLatch, however, when user asks fortoCompletableFuture,NettyResponseFuturenow returns already allocatedCompletableFutureobject withoutRunnableregistration inAbstractListenableFuture.Also, I believe that
CompletableFutureis well optimized.Tests pass, although it is hard to tell if anything is broken, because
NettyResponseFutureimplementation is hard.