Bumping POM dependencies, setting DNS server #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Diagoras thanks! |
|
Because of this commit, tests fail on OSX on my notebook. Because "localhost" becomes "localhost.yandex.ru" (because "yandex.ru" is in the list of search domains in my network setup), which is resolved to I'd revert this commit. |
|
@stepancheg As you might know, the DNS related modules are backports from Netty 4.1. So your problem actually happens upstream and you're probably not able to run Netty tests either. ping @normanmaurer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some properties to the POM to set the DNS server used in tests to Google's. This will hopefully make builds more consistently reproducible, especially for people like me who have an ISP that likes to mess with the responses for incorrect DNS queries. :(
Also bumped the versions of the various Maven plugins, because why not?