Fixed bug with cookie handling #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added limit of 2 fields to split in parseCookie, to be able to handle cookies such as: Set-Cookie: PREF=ID=a3be7e468f2a528c:FF=0:TM=1347369...
|
Thanks. Can you attach a test case as well? That would be perfect :-) |
|
Sorry to bump in, but are you sure that having an = character in a cookie value is valid? |
|
Well, I've looked around at various sources. Some suggest encoding, but say it's not required. From what I can see the value is just everything up to the ; or end of the string. Plus that cookie I put in my original comment came from google.com, so it's probably best that it is supported. I'll come up with a test case for it. |
|
Well, it looks like it's definitively required by the RFCs, but internet is such a mess and nobody gives a damn... |
|
Testcase added |
|
Is there any plan to merge this? |
|
+1 |
jfarcand
added a commit
that referenced
this pull request
Nov 5, 2012
Fixed bug with cookie handling
|
@jfarcand Could you backport this on the 1.7.x branch, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added limit of 2 fields to split in parseCookie, to be able to handle cookies such as:
Set-Cookie: PREF=ID=a3be7e468f2a528c:FF=0:TM=1347369...