Skip to content

Fix NullPointerException in NTLM auth #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2017
Merged

Fix NullPointerException in NTLM auth #1386

merged 1 commit into from
Apr 3, 2017

Conversation

dwickern
Copy link
Contributor

I'm getting an NPE after upgrading to version 2.0.24.

Workaround is to set the system property http.auth.ntlm.domain to a valid domain, or even empty string.

Introduced by #1185.

java.lang.NullPointerException: null
    at org.asynchttpclient.ntlm.NtlmEngine.convertDomain(NtlmEngine.java:158)
    at org.asynchttpclient.ntlm.NtlmEngine.access$1800(NtlmEngine.java:52)
    at org.asynchttpclient.ntlm.NtlmEngine$Type3Message.<init>(NtlmEngine.java:1079)
    at org.asynchttpclient.ntlm.NtlmEngine.getType3Message(NtlmEngine.java:136)
    at org.asynchttpclient.ntlm.NtlmEngine.generateType3Msg(NtlmEngine.java:1529)
    at org.asynchttpclient.netty.handler.intercept.Unauthorized401Interceptor.ntlmChallenge(Unauthorized401Interceptor.java:202)
    at org.asynchttpclient.netty.handler.intercept.Unauthorized401Interceptor.exitAfterHandling401(Unauthorized401Interceptor.java:133)
    at org.asynchttpclient.netty.handler.intercept.Interceptors.exitAfterIntercept(Interceptors.java:77)
    at org.asynchttpclient.netty.handler.HttpHandler.handleHttpResponse(HttpHandler.java:130)
    at org.asynchttpclient.netty.handler.HttpHandler.handleRead(HttpHandler.java:184)
    at org.asynchttpclient.netty.handler.AsyncHttpClientHandler.channelRead(AsyncHttpClientHandler.java:76)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:367)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:353)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:346)
    at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:86)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:367)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:353)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:346)
    at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:367)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:353)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:346)
    at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435)
    at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293)
    at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:280)
    at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:396)
    at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:248)
    at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:367)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:353)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:346)
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:367)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:353)
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911)
    at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)
    at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:652)
    at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:575)
    at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:489)
    at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:451)
    at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
    at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
    at java.lang.Thread.run(Thread.java:745)

slandelle
slandelle requested changes Apr 1, 2017
View reviewed changes
client/src/main/java/org/asynchttpclient/ntlm/NtlmEngine.java Outdated
@@ -150,11 +150,17 @@ private static String stripDotSuffix(final String value) {

/** Convert host to standard form */
private static String convertHost(final String host) {
if (host == null) {
return null;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ? ternary operator

client/src/main/java/org/asynchttpclient/ntlm/NtlmEngine.java Outdated
return stripDotSuffix(host).toUpperCase();
}

/** Convert domain to standard form */
private static String convertDomain(final String domain) {
if (domain == null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ? ternary operator

@slandelle
Copy link
Contributor

Thanks!
Could you please address comments?

@slandelle slandelle merged commit 9ed0991 into AsyncHttpClient:master Apr 3, 2017
@slandelle slandelle added this to the 2.0.32 milestone Apr 3, 2017
@slandelle
Copy link
Contributor

Thanks!

slandelle pushed a commit that referenced this pull request Apr 3, 2017
@dwickern @slandelle
Fix NullPointerException in NTLM auth (#1386)
4f421a0
@dwickern dwickern deleted the domain-npe branch April 3, 2017 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slandelle slandelle slandelle requested changes

Assignees
No one assigned
Labels
Defect
Projects
None yet
Milestone
2.0.32
Development

Successfully merging this pull request may close these issues.
2 participants
@dwickern @slandelle