HTTP 1.1 keepalive is only determined by presence of Connection: close. #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connection:close header instead of keep-alive presence.
jfarcand
added a commit
that referenced
this pull request
Oct 2, 2012
HTTP 1.1 keepalive is only determined by presence of Connection: close.
|
Agree, thanks! |
|
However, this doesn't fix an issue we're having. The target server isn't sending a Connection: header at all. So |
|
Salut, I would needs a unit test for reproducing...I'm not active on AHC those days and I can be dangerous :-) So if you have a unit test I can take a look. |
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC for HTTP 1.1 only states that keepalive should be terminated on presence of Connection:close. The default behavior in 1.1 is to keep the connection open, so the presence of a Connection: keep-alive is optional. I believe the keep-alive status was for 1.0 persistent connection negotiation.
This patch doesn't look at the HTTP version. The existing code would have had issues with 1.0 as well, so I'm assuming we can safely ignore that.
The grizly provider seems to have the proper logic in it already.