Fixes #1420 #1422
Fixes #1420 #1422
Conversation
| @@ -281,4 +281,10 @@ | |||
| * @param predicate the predicate | |||
| */ | |||
| void flushChannelPoolPartitions(Predicate<Object> predicate); | |||
|
|
|||
There was a problem hiding this comment.
Please format and remove spaces
| @@ -276,4 +276,9 @@ protected BoundRequestBuilder requestBuilder(String method, String url) { | |||
| protected BoundRequestBuilder requestBuilder(Request prototype) { | |||
| return new BoundRequestBuilder(this, prototype).setSignatureCalculator(signatureCalculator); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please format and remove spaces
| @@ -134,4 +134,9 @@ public ClientStats getClientStats() { | |||
| public void flushChannelPoolPartitions(Predicate<Object> predicate) { | |||
| throw new UnsupportedOperationException(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please format and remove spaces
| @@ -138,4 +138,9 @@ public ClientStats getClientStats() { | |||
| public void flushChannelPoolPartitions(Predicate<Object> predicate) { | |||
| throw new UnsupportedOperationException(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please format and remove spaces
|
@slandelle What is your formatting preference? Note that the above notes are pieces of code that I did not touch. |
Of course you did. Those are all the places you added new methods. When you hit enter to jump line, your IDE doesn't create an empty line, but one with as many white spaces as the previous cursor position. Those are the ones I ask you to remove to I don't have to reformat after merging your PR. |
|
@slandelle My bad! 😭 Darn non-printable characters. The extra spaces should no longer be there. |
|
Thanks :) |
@slandelle Please review :)