added: typesafe config integration extras module #1500
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slandelle
reviewed
Jan 18, 2018
| @@ -0,0 +1,397 @@ | |||
| /* | |||
| * Copyright (c) 2015 AsyncHttpClient Project. All rights reserved. | |||
slandelle
reviewed
Jan 18, 2018
| @@ -0,0 +1,121 @@ | |||
| /* | |||
| * Copyright (c) 2015 AsyncHttpClient Project. All rights reserved. | |||
|
@coutoPL Could you please:
Thanks! |
Current implemenation does not have any integration with popular config library. Modifications: Added extras module with Typesafe Config integration and provided AHC config wrapper for mentioned lib. Result: AsyncHttpClient can be initialized with Typesafe Config file.
coutoPL
force-pushed
the
feature/typesafeconfig
branch
from
029fa53 to
a220b71
Compare
slandelle
added a commit
that referenced
this pull request
Jan 19, 2018
Motivation: Bump minor version before merging #1500 that brings a new feature Modification: Bump to 1.2.0-SNAPSHOT Result: New minor version
|
cherry-picked as 60a8fe2 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Current implemenation does not have any integration with popular config library.
Modifications:
Added extras module with Typesafe Config integration and provided AHC config wrapper for mentioned lib.
Result:
AsyncHttpClient can be initialized with Typesafe Config object.