Added toBuilder methods to Request #1673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for #1672
@slandelle These are the simple/minimum changes.
But there is the fact that the constructors of RequestBuilder that take a prototype remain and could be used directly, breaking again the purpose of this change.
But in order to overcome that a more impactful change (backwards incompatible) has to be made. But I would leave that decision to you or your opinion on it.
Bonus question:
Do you prefer the implementation of toBuilder methods as default implementation on the interface or as it is now on the DefaultRequest.java?