use createHttpClientCodec to use user defined parameters #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1405,14 +1405,14 @@ private void upgradeProtocol(ChannelPipeline p, String scheme) throws IOExceptio | |||
|
|
|||
| if (isSecure(scheme)) { | |||
| if (p.get(SSL_HANDLER) == null) { | |||
| p.addFirst(HTTP_HANDLER, new HttpClientCodec()); | |||
| p.addFirst(HTTP_HANDLER, createHttpClientCodec); | |||
|
@vtheron Thanks for the PR. However, it's against 1.7.x while 1.7.12 was supposed to be the last release on this branch... |
|
@slandelle ok. I thought 1.7.13 would be released eventually. I am using 1.7.x for my project and needed this fix. |
slandelle
pushed a commit
that referenced
this pull request
Mar 18, 2013
use createHttpClientCodec to use user defined parameters
|
I'll port your fix on master. |
|
The problem actually exists only in 1.7.x. Yet another example of double maintenance mess. |
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The private method upgradeProtocol was not using user defined parameters when creating a new HttpClientCodec for netty.