Fix sending multipart bodies through SocketChannel #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2013 10:42
As per documentation, selector.select() returns only keys that have updated and therefore even if it return zero, it doesn't mean that selectedKeys wouldn't contain keys that are writable. See http://stackoverflow.com/questions/9939989/java-nio-selector-select-returns-0-although-channels-are-ready and http://docs.oracle.com/javase/7/docs/api/java/nio/channels/Selector.html#select() for more details. This commit utilizes the same maxSpin already used in FileChannel case for detecting that writing has stuck somewhere. A configurable timeout for select would be the obvious better solution.
Some servers, e.g. Jetty save multipart parts with filename present in content disposition header to disk. To prevent this we want to be able to send Content-Disposition header with name only (so we can easily access it) but not store bytes to disk to prevent unwanted IO.
jfarcand
added a commit
that referenced
this pull request
Oct 2, 2013
Fix sending multipart bodies through SocketChannel
|
backport on master? |
|
ported on master |
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per documentation, selector.select() returns only keys that have
updated and therefore even if it return zero, it doesn't mean that
selectedKeys wouldn't contain keys that are writable.
See http://stackoverflow.com/questions/9939989/java-nio-selector-select-returns-0-although-channels-are-ready and http://docs.oracle.com/javase/7/docs/api/java/nio/channels/Selector.html#select() for more details.
This commit utilizes the same maxSpin already used in FileChannel case
for detecting that writing has stuck somewhere. A configurable
timeout for select would be the obvious better solution.