Reuse the socket on a 401 #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If client requests keepalive and server allows it, reuse the socket
| @@ -2103,6 +2103,9 @@ public Object call() throws Exception { | |||
| } | |||
| }; | |||
|
|
|||
| if (future.getKeepAlive()) { | |||
There was a problem hiding this comment.
Separate if since we don't want to base resuse of socket on the chunked response.
slandelle
pushed a commit
that referenced
this pull request
Jan 24, 2014
slandelle
pushed a commit
that referenced
this pull request
Jan 30, 2014
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
Co-authored-by: George Barnett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a 401, the client was opening a new socket, regardless of the keeplive status. The client was sending keepAlive and the remote server was honoring it.
This patch sets reuseChannel if the keepalive was honored by the remote server.