OAuth signature calculator with userAuth#key check #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
haed
commented
Mar 19, 2014
haed
commented
- fixed 2 possible programming accidents:
- added return in a switch/case logic (ProxyUtils)
- a assignment instead of boolean comparing in RFC2616DateParser
- added a check if userAuth.key is null in OAuthSignatureCalculator, now this class can also be used to request access token in the OAuth1 dance (we can use this logic in the Evernote OAuth process now)
…an be used to acquire request token within the oauth dance logic
| @@ -83,7 +83,7 @@ private Tokens tokenize() { | |||
| } | |||
|
|
|||
| // finish lastToken | |||
| if (inToken = true) | |||
| if (inToken == true) | |||
slandelle
pushed a commit
that referenced
this pull request
Mar 19, 2014
OAuth signature calculator with userAuth#key check
|
Thanks a lot! |
|
Thanks for merging. |
jamalsa
added a commit
to jamalsa/reboot
that referenced
this pull request
Jul 14, 2014
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
* make `Scheme` a type * introduce new Endpoint type * use endpoint as storage in `HTTPClient.Request` * fix merge conflicts * rename Endpoint to DeconstructedURL * swift-format * make `DeconstructedURL` properties `var`'s * move scheme into global namespace - rename `useTLS` to `usesTLS` where posible without breaking public API - only import Foundation.URL * fix review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.