511: GrizzlyAsyncHttpProvider not honoring usePreemtiveAuth #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elakito I just have one question: does this new test pass with the Netty provider too? |
|
@slandelle, |
|
Hi Stephane, and I wanted to ask you how do you want have the fix in 1.8.x. Shall I create another PR for it or can you cherry-pick/merge the fix |
|
No pro, I'll backport manually (I fear code base has changed too much for cherry-picking to work). |
slandelle
pushed a commit
that referenced
this pull request
Mar 26, 2014
511: GrizzlyAsyncHttpProvider not honoring usePreemtiveAuth
|
thanks. |
|
@elakito I tried to backport a bit blindly but the test fails. Could you issue a new PR for the 1.8.x branch please? |
|
@slandelle |
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
### Motivation To land support for async/await, we need test utilities. We already have a `MockRequestExecutor`. Let's improve this to better handle on and off `EventLoop` request processing. ### Changes - Move `MockRequestExecutor` into its own file - Add blocking APIs to `MockRequestExecutor` when called from another thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consisting of a modified
providers/grizzly/src/main/java/org/asynchttpclient/providers/grizzly/filters/AsyncHttpClientFilter.java
to make the preemptive auth mode working for grizzly.
a modified
api/src/test/java/org/asynchttpclient/async/BasicAuthTest.java
to correctly verify whether the auth header is actually sent in the initial message.
regards, aki