Fix for issue #72 #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in the body ApacheResponse.getResponseBodyAsStream() was returning an InputStream that only provided bytes from the first body part. Pulled JDKResponse's ByteArrayCollectionInputStream into its own class, HttpResponseBodyPartsInputStream, so it could be shared with ApacheResponse.
|
Agree. Thanks! |
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
motivaiton: unified format changes: * fix outstanding formatting issues * add a call to swiftformat as part of sanity script * fix sanity script language check debugging statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ApacheResponse.getResponseBodyAsStream() to return all the bytes in the body.
I'm not sure if I put the new class in the right package, or if the name was optimal (ByteArrayCollectionInputStream). Please re-arrange as you desire.