[master] Add handler extension callbacks after DNS resolution and SSL/TLS handshaking #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is groundwork for adding more events in AsyncHttpClient#732. Sadly I couldn’t put these higher up in the test hierarchy, because the Grizzly provider doesn’t seem to fire most events.
| @@ -0,0 +1,98 @@ | |||
| package org.asynchttpclient.async.util; | |||
There was a problem hiding this comment.
Hye, can you add the license header? Thanks
slandelle
pushed a commit
that referenced
this pull request
Oct 28, 2014
[master] Add handler extension callbacks after DNS resolution and SSL/TLS handshaking, close #732
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #732 by adding two additional callbacks to the
AsyncHandlerExtensionsclass:onDnsResolvedandonSslHandshakeCompleted.I made an effort to ensure that no additional tests are failing over what was already failing on master.
Implemented with @kstokoz.