SpnegoEngine modifications for thread safety #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variables instead of class attributes. (gssContext must not be thread safe as it makes NPE under load)
jfarcand
added a commit
that referenced
this pull request
Apr 25, 2012
SpnegoEngine modifications for thread safety
|
Thanks!!!! |
slandelle
pushed a commit
that referenced
this pull request
Mar 7, 2014
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
This commit fixes AsyncHttpClient#95 by always hopping event loop futures received from the delegate to the right event loop. This could be a source of bugs if the library users forgot to hop(to:) futures from their delegates implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some class attributes should be defined as local variables for thread safety.
(mainly gssContext, it must not be thread safe as it makes NPE under load). Problem discovered using gatling to load test a CAS / SPNEGO server.