Skip to content

Conversation

@rsasaki0109
Copy link
Contributor

Hi.I inplemented Pose Optimization SLAM 3D.

Please advise me if you want this PR be merged.

@coveralls
Copy link

coveralls commented Sep 7, 2019

Pull Request Test Coverage Report for Build 988

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 89.877%

Files with Coverage Reduction New Missed Lines %
PathPlanning/RRT/rrt_with_pathsmoothing.py 22 61.11%
Totals Coverage Status
Change from base Build 982: -0.07%
Covered Lines: 6659
Relevant Lines: 7409

💛 - Coveralls

@AtsushiSakai
Copy link
Owner

@rsasaki0109 Oh. Thank you so much for your great PR!!. I love it. However, this code does not work in my environment. Could you please let me know your python version and numpy version?

@rsasaki0109
Copy link
Contributor Author

rsasaki0109 commented Sep 7, 2019

@AtsushiSakai
My enivironments are as follows;
Python:3.6.8
numpy:1.17.1

What is the problem?

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss it in the review.

@AtsushiSakai
Copy link
Owner

This pull request introduces 1 alert when merging 4beee9b into 4e76b94 - view on LGTM.com

new alerts:

  • 1 for Unused import

Warning - Automated code review for AtsushiSakai/PythonRobotics will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2019

This pull request introduces 1 alert when merging d147df5 into 4e76b94 - view on LGTM.com

new alerts:

  • 1 for Unused import

@AtsushiSakai AtsushiSakai merged commit 57e0dd2 into AtsushiSakai:master Sep 7, 2019
@AtsushiSakai
Copy link
Owner

@rsasaki0109 Cool!! I will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants