- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 6.9k
 
fix #233 improve check segment intersection with obstacle #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #233 improve check segment intersection with obstacle #241
Conversation
The previous method only worked because the step that checked collision from a point of the line to obstacles was the same as the minimum obstacle radius. If the obstacle radius is very small a great amount of steps would be required. Thus It's better to check the distance from the segment to the obstacles directly and compare with obstacle radius Now there is no need to have two check functions.
          Pull Request Test Coverage Report for Build 1047
 
 
 
 💛 - Coveralls | 
    
| 
           @FranciscoMoretti Thank you for your help!!  | 
    
| 
           @alex-ira Could you please check this PR fix your issue #233  | 
    
| 
           @AtsushiSakai Sorry for late reply - been busy lately. I though it did but then got this (with expandDis = 7 - not sure if it is due to not using path_resolution in checking for collisions): Generally, I get poor performance and many times the path cannot be find (using "reasonable" maxIter). It seems to me that a lot of issues come from checking collisions.  | 
    
| 
           @alex-ira Thank you for your checking.  | 
    
| 
           @karanchawla Could you review the code?  | 
    
| 
           Sorry for the delay. I've been a little bit busy.  | 
    
| 
           In several experiments, it looks working correletry, so I merge it. @FranciscoMoretti Thank you!!  | 
    
| 
           @AtsushiSakai Thanks you!!! :)  | 
    

The previous method only worked because the step that checked collision
from a point of the line to obstacles was the same as the minimum
obstacle radius. If the obstacle radius is very small a great amount of
steps would be required.
Thus It's better to check the distance from the segment to the obstacles
directly and compare with obstacle radius
Now there is no need to have two check functions.
Example with same parameters as the issue:
