Skip to content

Conversation

@FranciscoMoretti
Copy link
Contributor

The previous method only worked because the step that checked collision
from a point of the line to obstacles was the same as the minimum
obstacle radius. If the obstacle radius is very small a great amount of
steps would be required.
Thus It's better to check the distance from the segment to the obstacles
directly and compare with obstacle radius
Now there is no need to have two check functions.

Example with same parameters as the issue:
informed rrt

The previous method only worked because the step that checked collision
from a point of the line to obstacles was the same as the minimum
obstacle radius. If the obstacle radius is very small a great amount of
steps would be required.
Thus It's better to check the distance from the segment to the obstacles
directly and compare with obstacle radius
Now there is no need to have two check functions.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1047

  • 17 of 18 (94.44%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 90.361%

Changes Missing Coverage Covered Lines Changed/Added Lines %
PathPlanning/InformedRRTStar/informed_rrt_star.py 17 18 94.44%
Files with Coverage Reduction New Missed Lines %
PathPlanning/ClosedLoopRRTStar/closed_loop_rrt_star_car.py 2 70.54%
Totals Coverage Status
Change from base Build 1041: -0.03%
Covered Lines: 6703
Relevant Lines: 7418

💛 - Coveralls

@AtsushiSakai
Copy link
Owner

@FranciscoMoretti Thank you for your help!!

@AtsushiSakai
Copy link
Owner

#233

@AtsushiSakai
Copy link
Owner

@alex-ira Could you please check this PR fix your issue #233

@4lexir4
Copy link

4lexir4 commented Oct 23, 2019

@AtsushiSakai Sorry for late reply - been busy lately. I though it did but then got this (with expandDis = 7 - not sure if it is due to not using path_resolution in checking for collisions):

issue

Generally, I get poor performance and many times the path cannot be find (using "reasonable" maxIter). It seems to me that a lot of issues come from checking collisions.

@AtsushiSakai
Copy link
Owner

@alex-ira Thank you for your checking.
@FranciscoMoretti Could you please fix the problem?

@AtsushiSakai
Copy link
Owner

@karanchawla Could you review the code?

@FranciscoMoretti
Copy link
Contributor Author

Sorry for the delay. I've been a little bit busy.
@alex-ira I've found that the problem that you mentioned in the comment was because the solution node there satisfied the condition for "is near goal". The segment from the node to the goal went through obstacles because the script didn't check for collision when a node satisfied that condition.
I''ve added the missing checking in 178dca3 and it seems to be working fine now.

@AtsushiSakai
Copy link
Owner

In several experiments, it looks working correletry, so I merge it. @FranciscoMoretti Thank you!!

@AtsushiSakai AtsushiSakai merged commit a554811 into AtsushiSakai:master Nov 17, 2019
@FranciscoMoretti
Copy link
Contributor Author

@AtsushiSakai Thanks you!!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants