fix(sap): pass through extra params from allowed_openai_params #18432
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using
allowed_openai_paramswith the SAP provider, extra parameters(like Gemini's
thinking_config) are filtered out intransform_request.Solution
Extend
supported_paramswith any extra params that passedget_optional_params()validation (via
allowed_openai_params).This is a generic fix - any new provider-specific params can be passed through
without code changes.
Changes
litellm/llms/sap/chat/transformation.py: 2 lines added intransform_requestFixes #18412