frontend: improve backup check related messages #3726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
benma
requested changes
Dec 18, 2025
| if (!check.success) { | ||
| setActiveDialog(true); | ||
| setMessage(t('backup.check.notOK')); | ||
| if (check.code === 104) { |
Contributor
There was a problem hiding this comment.
use errUserAbort from bitbox02.ts
| "checking": "Checking backup…", | ||
| "confirmTitle": "Check backup", | ||
| "notOK": "Backup does NOT match the wallet.", | ||
| "notOK": "No backups on the microSD card matched the wallet on the BitBox. This can occur if you inserted a microSD card that was used to set-up another BitBox. Please locate the correct microSD card used to set-up this BitBox and try again.", |
Contributor
There was a problem hiding this comment.
Did you change it on locize too?
Collaborator
Author
There was a problem hiding this comment.
not yet, but once this is merged I will. I need to keep it here else I'll forget about it.
Collaborator
Author
There was a problem hiding this comment.
I can remove it, if you approve the PR and I update locize. But then the issue isn't fixed until you pull.
The app only displayed "Backup does NOT match the wallet" without any further information. This message was shown in cases where the user aborted on the device, or also when there was no matching backup. Added a custom aborted message and improved the does-not-match message, with some more information.
thisconnect
force-pushed
the
frontend-improve-backupcheck-message
branch
from
60f177b to
af8004e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app only displayed "Backup does NOT match the wallet" without any further information. This message was shown in cases where the user aborted on the device, or also when there was no matching backup.
Added a custom aborted message and improved the does-not-match message, with some more information.