Ble improvements #1727
Open
Ble improvements #1727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 23, 2025 22:36
The serial-link parser subtracts 5 bytes (type+len+crc) when validating a frame. If a truncated frame reaches SERIAL_LINK_STATE_CHECK with frame_len < 5, the subtraction underflows, allowing out-of-bounds reads during CRC/length handling. Reject frames shorter than the minimum header+CRC size before parsing the length.
The serial-link frame buffer is byte-addressed. Casting &frame[1] / &frame[3+len] to a uint16_t* can be unaligned, which is undefined behavior in C. Decode the little-endian length and CRC fields bytewise instead of via unaligned uint16_t loads.
The BLE HWW path previously relied on ASSERT(payload_length == 64), which is compiled out in release builds. Enforce the expected USB HID report size at runtime and drop malformed frames so usb_packet_process() never consumes stale/partial payload bytes. Also include the headers that define USB_REPORT_SIZE and USB_FRAME explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.