Fix the mobile menu problems and clean up js code. #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fediev
commented
Mar 10, 2015
fediev
commented
- Fix the problem that show menu click does not work after the first click.
- Clean up indentation, trailing spaces and revise some codes for clean coding style.
- Remove unnecessary codes and jQuery.browser.mobile plugin.
In the event handler, 'this' is not a jquery object, but a DOM object. Instead of using $(this) to fix this problem, $mainNav is used because it is already created and no need to be re-wrapped as jquery object. $varname style is used for preventing this type of problem.
in this code, 'this' in the scope is correct this. no need to use 'that'
css handling is done by css media query
Mobile device checking is done by css media query. jQuery.browser.mobile plugin is not needed any more.
|
Looks good, thanks! |
peterjwest
added a commit
that referenced
this pull request
Mar 17, 2015
Fix the mobile menu problems and clean up js code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.