Update to CastXML 0.4.3 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, update file names for targeted version as ARM versions are now available from the data.kitware.com download site. Update formatting to contain previously manual changes.
jcfr
requested changes
May 27, 2021
There was a problem hiding this comment.
To address TravisCI failure, I suggest to backport scikit-build/cmake-python-distributions@fdac18b#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
Add additional message to describe Windows binary packaging Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
|
The Travis failure seemed to be the fault of |
This was referenced May 27, 2021
Makes sense, thanks for creating the issue and for taking care of the release 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, update file names for targeted version as ARM versions are now
available from the data.kitware.com download site.
Update formatting to contain previously manual changes.