Skip to content

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Sep 14, 2025

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

This tries to reduce the number of string clones when collecting usernames, by storing them in a Option<Arc<str>> up until we display them.

This also pulls in some refactors from #1807.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Sep 14, 2025

Codecov Report

❌ Patch coverage is 11.53846% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.48%. Comparing base (c8614bf) to head (aaa69b4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/widgets/process_table/process_data.rs 9.09% 10 Missing ⚠️
src/widgets/process_table/process_columns.rs 0.00% 4 Missing ⚠️
src/collection/processes/unix/user_table.rs 0.00% 3 Missing ⚠️
src/widgets/process_table/query.rs 0.00% 3 Missing ⚠️
src/collection/processes/linux/mod.rs 0.00% 1 Missing ⚠️
src/collection/processes/unix/process_ext.rs 0.00% 1 Missing ⚠️
src/collection/processes/windows.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
- Coverage   43.53%   43.48%   -0.05%     
==========================================
  Files         115      115              
  Lines       16302    16297       -5     
==========================================
- Hits         7097     7087      -10     
- Misses       9205     9210       +5     
Flag Coverage Δ
macos-14 37.34% <8.33%> (-0.01%) ⬇️
ubuntu-latest 45.08% <12.50%> (-0.08%) ⬇️
windows-2022 37.68% <9.52%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ClementTsang ClementTsang force-pushed the refactor_uid_to_username branch from f5d1cfe to 5e844b7 Compare September 15, 2025 00:54
@ClementTsang ClementTsang merged commit e4b814f into main Sep 15, 2025
37 checks passed
@ClementTsang ClementTsang deleted the refactor_uid_to_username branch September 15, 2025 03:47
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Oct 10, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ClementTsang/bottom](https://github.com/ClementTsang/bottom) | patch | `0.11.1` -> `0.11.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>ClementTsang/bottom (ClementTsang/bottom)</summary>

### [`v0.11.2`](https://github.com/ClementTsang/bottom/blob/HEAD/CHANGELOG.md#0112---2025-10-07)

[Compare Source](ClementTsang/bottom@0.11.1...0.11.2)

##### Features

- [#&#8203;1793](ClementTsang/bottom#1793): Add support for threads in Linux.
- [#&#8203;1719](ClementTsang/bottom#1719): Support ignoring all keypresses.
- [#&#8203;1772](ClementTsang/bottom#1772): Support hiding kernel threads.

##### Bug Fixes

- [#&#8203;1800](ClementTsang/bottom#1800): Fix colon at end of process name in Linux.
- [#&#8203;1804](ClementTsang/bottom#1804): Draw average CPU last again.
- [#&#8203;1811](ClementTsang/bottom#1811): Fix drawing average CPU in basic mode when dedicated row is enabled.
- [#&#8203;1817](ClementTsang/bottom#1817): Fix builds for FreeBSD on ARM/PowerPC due to `libc::c_char` data type being different.
- [#&#8203;1821](ClementTsang/bottom#1821): Use alpha version of ratatui version which fixes drawing at high resolutions.
- [#&#8203;1827](ClementTsang/bottom#1827): Fix crash for Windows where the network widget could cause a crash if the program started too quickly after boot under certain settings.

##### Other

- [#&#8203;1801](ClementTsang/bottom#1801): Build and check Windows ARM.
- [#&#8203;1816](ClementTsang/bottom#1816): Optimize username cloning on Unix.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjQxLjE0MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant