Skip to content

Fix chain_getMinTransactionFee to take null as the block number #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2019
Merged

Fix chain_getMinTransactionFee to take null as the block number #1549

merged 2 commits into from
May 21, 2019

Conversation

@sgkim126
Copy link
Contributor

No description provided.

@sgkim126 sgkim126 added the rpc label May 21, 2019
@sgkim126 sgkim126 requested a review from majecty May 21, 2019 01:11
@sgkim126 sgkim126 changed the title Fix chain_getMinTransactionFee to take null as block number Fix chain_getMinTransactionFee to take null as the block number May 21, 2019
@sgkim126
Copy link
Contributor Author

sgkim126 commented May 21, 2019 •
edited
Loading

It depends on #1546.
I'll remove do-not-merge after merging #1546

@sgkim126 sgkim126 added the do-not-merge Do not merge (for mergify.io) label May 21, 2019
Fix chain_getMinTransactionFee to take null as the block number
498233b 
Null means the transaction fee of the latest block.
@sgkim126 sgkim126 removed the do-not-merge Do not merge (for mergify.io) label May 21, 2019
@sgkim126
Copy link
Contributor Author

@majecty The dependencies are merged. Please review it.

majecty
majecty approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@majecty majecty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit cde87c1 into CodeChain-io:master May 21, 2019
@sgkim126 sgkim126 deleted the rpc-min branch May 21, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majecty majecty majecty approved these changes

Assignees

No one assigned

Labels

rpc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sgkim126 @majecty