Skip to content

Fix a memory leak in header downloader's downloaded #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Fix a memory leak in header downloader's downloaded #1749

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28f4c38
Fix a memory leak in header downloader's downloaded
majecty Aug 28, 2019
6c09546
Merge branch 'master' into f/memory-leak-downloader
mergify[bot] Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sync/src/block/downloader/header.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ impl HeaderDownloader {
pub fn mark_as_imported(&mut self, hashes: Vec<H256>) {
for hash in hashes {
self.queued.remove(&hash);
self.downloaded.remove(&hash);

if self.best_hash == hash {
self.pivot = Pivot {
Expand All @@ -188,6 +189,7 @@ impl HeaderDownloader {
}
}
self.queued.shrink_to_fit();
self.downloaded.shrink_to_fit();
}

pub fn mark_as_queued(&mut self, hashes: Vec<H256>) {
Expand Down