Do not generate a seal if the block is generated from a past view #1807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foriequal0
requested changes
Oct 7, 2019
| assert!(self.is_signer_proposer(&parent_hash)); | ||
| // We don't know at which view the node starts generating a block. | ||
| // If this node's signer is not proposer at the current view, return none. | ||
| if self.is_signer_proposer(&parent_hash) { |
There was a problem hiding this comment.
Suggested change
| if self.is_signer_proposer(&parent_hash) { | |
| if !self.is_signer_proposer(&parent_hash) { |
| // We don't know at which view the node starts generating a block. | ||
| // If this node's signer is not proposer at the current view, return none. | ||
| if self.is_signer_proposer(&parent_hash) { | ||
| cwarn!(ENGINE, "Proposer is generated after view change"); |
There was a problem hiding this comment.
Suggested change
| cwarn!(ENGINE, "Proposer is generated after view change"); | |
| cwarn!(ENGINE, "View is changed after requesting the seal"); |
There was a problem hiding this comment.
View is not changed after the seal request. View is changed after the block generation request.
What do you think about "Seal request for an old view"?
majecty
force-pushed
the
f/do-not-generate-seal
branch
2 times, most recently
from
d259882 to
b6362cd
Compare
foriequal0
previously approved these changes
Oct 7, 2019
ScarletBlue
changed the title
If generating a block takes too much time, the view could be changed before the miner module requests the signature. If the Tendermint module receives a signature request of an old view, it should ignore the message. Before this commit, the Tendermint module was crashing when it gets a signature request from an old view.
majecty
force-pushed
the
f/do-not-generate-seal
branch
from
b6362cd to
d6cf766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If generating a block takes too much time, the view could be changed
before the miner module requests the signature. If the Tendermint
module receives a signature request of an old view, it should ignore
the message. Before this commit, the Tendermint module was
crashing when it gets a signature request from an old view.
It fixes #1805.