Skip to content

Conversation

@AetherPrior
Copy link

What does this PR do?

  • Upgrade rust dependencies
  • Remove pointer to ~/.cargo/bin to use environment's cargo install as opposed to the system's install

Fixes #7

Who can review?

@CoderPat

Copy link
Owner

@CoderPat CoderPat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (the color additions are nice, thanks 🙏 )

@AetherPrior
Copy link
Author

I'm unsure why the build failed; could you kick it off again? The logs are missing.

@CoderPat
Copy link
Owner

I'm unsure why the build failed; could you kick it off again? The logs are missing.

Ye, weird, I ran it again and it failed again... Maybe something with the colors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clap_derive fails to build; TGI requires version bump in setup_scripts/conda_server.sh

2 participants