Adding capability to stream off of a primary when deployed via Helm #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in PGOv5.3, removing requirement to specify a repo when standby is enabled.
genofire
reviewed
Feb 17, 2023
| standby: | ||
| enabled: {{ .Values.standby.enabled }} | ||
| repoName: {{ required "repoName must be set when enabling standby mode." .Values.standby.repoName }} | ||
| repoName: {{ .Values.standby.repoName }} |
There was a problem hiding this comment.
should be more flexible (with lease code):
Suggested change
| repoName: {{ .Values.standby.repoName }} | |
| {{- with .Values.standby }} | |
| standby: | |
| {{ toYaml . | nindent 4 }} | |
| {{- end }} |
There was a problem hiding this comment.
More flexible, but the actual resource definition accepts only certain values anyway, and with so few values this seems to be an acceptable number of lines of code.
tjmoore4
reviewed
Feb 18, 2023
There was a problem hiding this comment.
@dajeffers This looks great! We just need two small adjustments to merge.
…g more realistic values for host and port.
tjmoore4
reviewed
Feb 21, 2023
tjmoore4
pushed a commit
to tjmoore4/postgres-operator-examples
that referenced
this pull request
Feb 22, 2023
…runchyData#185) * Adding capability to stream off of a primary due to feature addition in PGOv5.3, removing requirement to specify a repo when standby is enabled. * Removing outdated comment about required standby values and specifying more realistic values for host and port. * Changing port value to an integer Issue: [sc-17928]
tjmoore4
pushed a commit
that referenced
this pull request
Feb 23, 2023
…185) * Adding capability to stream off of a primary due to feature addition in PGOv5.3, removing requirement to specify a repo when standby is enabled. * Removing outdated comment about required standby values and specifying more realistic values for host and port. * Changing port value to an integer Issue: [sc-17928]
tjmoore4
pushed a commit
to tjmoore4/postgres-operator-examples
that referenced
this pull request
Jul 17, 2023
…runchyData#185) * Adding capability to stream off of a primary due to feature addition in PGOv5.3, removing requirement to specify a repo when standby is enabled. * Removing outdated comment about required standby values and specifying more realistic values for host and port. * Changing port value to an integer Issue: [sc-17928]
tjmoore4
pushed a commit
to tjmoore4/postgres-operator-examples
that referenced
this pull request
Jul 17, 2023
…runchyData#185) * Adding capability to stream off of a primary due to feature addition in PGOv5.3, removing requirement to specify a repo when standby is enabled. * Removing outdated comment about required standby values and specifying more realistic values for host and port. * Changing port value to an integer Issue: [sc-17928]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the operator now supports standby clusters with streaming replication, support for this ought to be built into the postgres Helm chart.