fix(appsec): enable SpanProcessor through the ddtrace product interface #647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables the AppSec
ProductwhenDD_APPSEC_ENABLEDis set.Motivation
With DataDog/dd-trace-py@7bfeeb0 (to be released in 3.12), Appsec has moved from being enabled by default by the tracer to being enabled through a
Product.Outside of lambda (when started with
ddtrace-runorimport ddtrace.auto) products are automatically gathered by aProductManagerand started based on the configuration.This step does not happen in lambda and individual products that we want to make available to lambda need to be started manually. This is what I am doing for Appsec.
Testing Guidelines
Manually. I don't see how I could test this in unit tests. Suggestions welcome.
It will eventually be caught by system-tests once this PR is ready: DataDog/system-tests#4891
Additional Notes
Types of Changes
Check all that apply