-
Notifications
You must be signed in to change notification settings - Fork 308
Add support for Fuji's CropMode tag (0.27->master) #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Fuji's CropMode tag (0.27->master) #1407
Conversation
kmilos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translated values are incomplete?
Good spot. I have fixed the issue when the tag value is one. As an aside, when this tag is 2 or 4 the image has an additional 1.25 crop factor attached to it. However, this does not appear to be reflected in the |
It's not a job for Exiv2 to "fix" (hide) this IMHO. |
|
Let's try to minimise "interpreting" the metadata. It's like the lens recognition which should never have been in Exiv2. It has created end-less work. So, let's do as little as possible. If you have to do this "when there is an R in the month, multiply by 1.25, you'll have to do it in code by supplying a specialised |
|
There is a PrintFnc already defined: 862 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance/build $ exiv2 -pt -g 35 ~/Downloads/sample1.raf
Exif.Photo.FocalLengthIn35mmFilm Short 1 83.0 mm
863 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance/build $ The tag is written by the manufacturer in Exif.Photo.FocalLengthIn35mmFilm. All the PrintFct does is to decorate the output: std::ostream& print0xa405(std::ostream& os, const Value& value, const ExifData*)
{
long length = value.toLong();
if (length == 0) {
os << _("Unknown");
}
else {
os << length << ".0 mm";
}
return os;
} |
|
Thanks you, Gentlemen for working on this. |
This small PR adds support for a missing tag in the Fuji Makernotes that I've discovered I need for my lens correction work. Details for the tag were taken from https://exiftool.org/TagNames/FujiFilm.html